DaanHoogland commented on a change in pull request #3638: UEFI Support on
CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r391694048
##########
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##########
@@ -1190,6 +1194,16 @@ private HypervisorType getHypervisorType(VMInstanceVO
vm, StoragePool srcVolumeP
throw ex;
}
+ UserVmDetailVO userVmDetailVO =
_UserVmDetailsDao.findDetail(vm.getId(), ApiConstants.BootType.UEFI.toString());
+ if (userVmDetailVO != null) {
+ s_logger.info(" Live Migration of UEFI enabled VM : " +
vm.getInstanceName() + " is not supported");
+ if ("legacy".equalsIgnoreCase(userVmDetailVO.getValue()) ||
"secure".equalsIgnoreCase(userVmDetailVO.getValue())) {
+ // Return empty list.
+ return new Ternary<Pair<List<? extends Host>, Integer>, List<?
extends Host>, Map<Host, Boolean>>(new Pair<List<? extends Host>,
+ Integer>(new ArrayList<HostVO>(), new Integer(0)), new
ArrayList<Host>(), new HashMap<Host, Boolean>());
+ }
+ }
Review comment:
please extract, see above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
