DaanHoogland commented on a change in pull request #3638: UEFI Support on
CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r391685994
##########
File path:
server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -256,6 +257,11 @@ private void setupAgentSecurity(final Connection
sshConnection, final String age
return null;
}
+ if (SSHCmdHelper.sshExecuteCmd(sshConnection, "rpm -qa | grep -i
ovmf", 3)) {
+ s_logger.debug("It's UEFI enabled KVM machine");
+ isUefiSupported = true;
+ }
+
Review comment:
please extract, see above
I think the message should be: "This is a UEFI enabled KVM machine"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services