DaanHoogland commented on a change in pull request #3638: UEFI Support on
CloudStack
URL: https://github.com/apache/cloudstack/pull/3638#discussion_r391689802
##########
File path:
server/src/main/java/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java
##########
@@ -123,11 +138,20 @@
String hostTagOnOffering = offering.getHostTag();
String hostTagOnTemplate = template.getTemplateTag();
+ String hostTagUefi = "UEFI";
boolean hasSvcOfferingTag = hostTagOnOffering != null ? true : false;
boolean hasTemplateTag = hostTagOnTemplate != null ? true : false;
List<HostVO> clusterHosts = new ArrayList<HostVO>();
+ List<HostVO> hostsMatchingUefiTag = new ArrayList<HostVO>();
+ if(isVMDeployedWithUefi){
+ hostsMatchingUefiTag = _hostDao.listByHostCapability(type,
clusterId, podId, dcId, Host.HOST_UEFI_ENABLE);
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug("Hosts with tag '" + hostTagUefi + "' are:" +
hostsMatchingUefiTag);
+ }
+ }
Review comment:
please extract, see above
I think it is not good to call this a tag, this already has a wide domain
usage that is not meant here. sugest something like "hosts with UEFI capability
are: " ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
