Pearl1594 commented on a change in pull request #3976: Enable sending hypervior
host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r399359205
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
##########
@@ -115,6 +118,30 @@ public Answer execute(final MigrateCommand command, final
LibvirtComputingResour
conn = libvirtUtilitiesHelper.getConnectionByVmName(vmName);
ifaces = libvirtComputingResource.getInterfaces(conn, vmName);
disks = libvirtComputingResource.getDisks(conn, vmName);
+
+ String oldIsoVolumePath = null;
+ for (DiskDef disk : disks) {
+ if (disk.getDiskPath() != null &&
disk.getDiskPath().contains(vmName)) {
+ oldIsoVolumePath = disk.getDiskPath();
+ break;
+ }
Review comment:
@DaanHoogland This actually tries to address an issue that exists which is
that when there is more than 1 datastore to chose from and the disk gets added
to one that isn't the same as before, it'll change the following mount point to
the new value: <source
file='/mnt/c3161722-2911-3345-b374-d36a8dbb2a25/i-2-4-VM.iso'/>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services