Pearl1594 commented on a change in pull request #3976: Enable sending hypervior 
host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r399344336
 
 

 ##########
 File path: 
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ##########
 @@ -1610,6 +1612,26 @@ public void finalizeUpdateInSequence(Network network, 
boolean success) {
         }
     }
 
+    @Override
+    public void addNewDisk(VirtualMachineProfile vm, DeployDestination dest) 
throws ResourceUnavailableException {
 
 Review comment:
   I'll change the name of this function - meant for mainly configDrive , but 
it's part of UserDataServiceProvider - will make it more meaningful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to