nvazquez commented on a change in pull request #3976: Enable sending hypervior
host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r401144136
##########
File path: engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java
##########
@@ -61,6 +61,12 @@
ConfigKey<Boolean> ResoureCountRunningVMsonly = new
ConfigKey<Boolean>("Advanced", Boolean.class,
"resource.count.running.vms.only", "false",
"Count the resources of only running VMs in resource limitation.",
true);
+ ConfigKey<Boolean> AllowExposeHypervisorHostnameAccoutLevel = new
ConfigKey<Boolean>("Advanced", Boolean.class, "allow.expose.host.hostname",
+ "false", "If set to true, it allows the hypervisor host name on
which the VM is spawned on to be exposed to the VM", true,
ConfigKey.Scope.Account);
+
+ ConfigKey<Boolean> AllowExposeHypervisorHostname = new
ConfigKey<Boolean>("Advanced", Boolean.class, "allow.expose.host.hostname",
Review comment:
This is why I asked to remove the 'account' name from the configuration. It
was only one configuration with scope = 'Account' so it could be overridden per
account, and if not, the global value is used
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services