DaanHoogland commented on a change in pull request #3976: Enable sending 
hypervior host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r399326270
 
 

 ##########
 File path: 
server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
 ##########
 @@ -765,6 +772,33 @@ public boolean saveSSHKey(final Network network, final 
NicProfile nic, final Vir
         return result;
     }
 
+    @Override
+    public boolean addNewDisk(NicProfile nicProfile, Network network, 
VirtualMachineProfile vm, DeployDestination dest) throws 
ResourceUnavailableException {
 
 Review comment:
   this one is certainly not adding any disk. we need to change that name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to