DaanHoogland commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r403971060
##########
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##########
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
- public List<Long> orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+ public List<Long> orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
yes, i read the code. Either zone_id or cluster_id should be null. What is
the use case of both being not null?
My point is; pass the cluster and find all storage pools for that cluster
either cluster wide or for the zone the cluster is in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
