weizhouapache commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r404011883
##########
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##########
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
- public List<Long> orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+ public List<Long> orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
@DaanHoogland as I said, if we pass the cluster id, it lists only
cluster-wide storage pools.
To list zone-wide storage pools, we should pass the zoneId/data_center_id
(and cluster_id should be NULL).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
