DaanHoogland commented on a change in pull request #4002: server: Search
zone-wide storage pool when allocation algothrim is firstfitleastconsumed
URL: https://github.com/apache/cloudstack/pull/4002#discussion_r403993481
##########
File path:
engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java
##########
@@ -903,20 +903,28 @@ public boolean removeBy(Short capacityType, Long zoneId,
Long podId, Long cluste
}
@Override
- public List<Long> orderHostsByFreeCapacity(Long clusterId, short
capacityTypeForOrdering){
+ public List<Long> orderHostsByFreeCapacity(Long zoneId, Long clusterId,
short capacityTypeForOrdering){
Review comment:
if we pass the cluster and deduce the zone from that, or if we deliberately
pass another zone than the cluster we are looking to deploy in? I don't see how
can it ever be another zone,except for a bad bug. Or do you mean a storage pool
that is used for multiple zones? I have not seen that before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
