sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r524260036
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -1465,11 +1543,17 @@ public void prepareForMigration(VirtualMachineProfile
vm, DeployDestination dest
long hostId = vm.getVirtualMachine().getHostId();
Host host = _hostDao.findById(hostId);
-
volService.grantAccess(volFactory.getVolume(newVol.getId()), host, destPool);
+ try {
+
volService.grantAccess(volFactory.getVolume(newVol.getId()), host, destPool);
+ } catch (Exception e) {
+ throw new StorageAccessException("Unable to grant
access to volume: " + newVol.getId() + " on host: " + host.getId());
+ }
Review comment:
> Curious, why we need to catch all _Exception_ here? And we are not
even logging it then
@shwstppr in order to retry the deployment, whenever granting access to a
disk fails in any case (chances are storage temporarily inaccessible, failure,
etc); and this is being logged in "_VirtualMachineManagerImpl
orchestrateStart()_"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
