sureshanaparti commented on a change in pull request #4304:
URL: https://github.com/apache/cloudstack/pull/4304#discussion_r524261256
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -574,6 +574,14 @@ private void
handleVolumeMigrationFromManagedStorageToNonManagedStorage(VolumeIn
}
}
+ private void verifyFormatWithPoolType(ImageFormat imageFormat,
StoragePoolType poolType) {
+ if (imageFormat != ImageFormat.VHD && imageFormat != ImageFormat.OVA
&& imageFormat != ImageFormat.QCOW2 &&
+ !(imageFormat == ImageFormat.RAW && StoragePoolType.PowerFlex
== poolType)) {
+ throw new CloudRuntimeException("Only the following image types
are currently supported: " +
+ ImageFormat.VHD.toString() + ", " +
ImageFormat.OVA.toString() + ", " + ImageFormat.QCOW2.toString() + ", and " +
ImageFormat.RAW.toString() + "(for PowerFlex)");
Review comment:
> Is this message in-line with the fact that we support PowerFlex only
for KVM right now?
yes, in-line with the RAW disk support with PowerFlex storage, for KVM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
