sureshanaparti commented on a change in pull request #4503:
URL: https://github.com/apache/cloudstack/pull/4503#discussion_r531576582
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3471,7 +3471,7 @@ private NetworkVO
createDefaultNetworkForAccount(DataCenter zone, Account owner,
s_logger.debug("Creating network for account " + owner + " from the
network offering id=" + requiredOfferings.get(0).getId() + " as a part of
deployVM process");
Network newNetwork =
_networkMgr.createGuestNetwork(requiredOfferings.get(0).getId(),
owner.getAccountName() + "-network", owner.getAccountName() + "-network",
null, null, null, false, null, owner, null, physicalNetwork,
zone.getId(), ACLType.Account, null, null, null, null, true, null, null,
- null);
+ null, null, null);
Review comment:
I see most of the calls, routerips are passed _null_ , can you add
another public method with routerip params and use it wherever required ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
