sureshanaparti commented on a change in pull request #4503:
URL: https://github.com/apache/cloudstack/pull/4503#discussion_r531580527
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateNetworkCmdByAdmin.java
##########
@@ -42,6 +42,12 @@
@Parameter(name=ApiConstants.HIDE_IP_ADDRESS_USAGE,
type=CommandType.BOOLEAN, description="when true ip address usage for the
network will not be exported by the listUsageRecords API")
private Boolean hideIpAddressUsage;
+ @Parameter(name = ApiConstants.ROUTER_IP, type = CommandType.STRING,
description = "IPV4 address to be assigned to a router in a shared network",
since = "4.16")
+ private String routerIp;
+
+ @Parameter(name = ApiConstants.ROUTER_IPV6, type = CommandType.STRING,
description = "IPV6 address to be assigned to a router in a shared network",
since = "4.16")
+ private String routerIpv6;
Review comment:
> Wouldn't adding such a validator make the field/ parameter mandatory?
I think it is for validating the parameter value when it is specified in the
cmd, nothing to do with required - true/false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
