Pearl1594 commented on a change in pull request #4503:
URL: https://github.com/apache/cloudstack/pull/4503#discussion_r531576198
##########
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##########
@@ -640,6 +640,19 @@ protected NetworkOrchestrator() {
setStateMachine();
}
+ private void updateNetworkDetails(NetworkVO networkPersisted, Network
network) {
+ NetworkDetailVO networkDetailVO = null;
+ if (isNotBlank(network.getRouterIp())) {
+ networkDetailVO = new NetworkDetailVO(networkPersisted.getId(),
ApiConstants.ROUTER_IP, network.getRouterIp().toString(), true);
+ }
+ if (isNotBlank(network.getRouterIpv6())) {
+ networkDetailVO = new NetworkDetailVO(networkPersisted.getId(),
ApiConstants.ROUTER_IPV6, network.getRouterIpv6().toString(), true);
Review comment:
But based on the code for persisting placeholder record, it seems like
one can specify both ipv4 and ipv6 details:
https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/network/router/NetworkHelperImpl.java#L715
(and L732)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
