sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539078136
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String>
details) {
Review comment:
> @sureshanaparti
> I was thinking about it. at the end I decided to pass vm details based on
two reasons
> (1) setCpuTopology is a complete function now. if pass coresPerSocket , we
need to get coresPerSocket out of the method.
> (2) it is better if add more cpu settings , for example the pr #4178
Ok @weizhouapache so going forward, cpu hyperthreading detail mentioned in
PR #4178 will be added to this method, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
