weizhouapache commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539235897



##########
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
 
         return false;
     }
+
+    private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String> 
details) {

Review comment:
       @sureshanaparti yes, this is a bug which should be fixed in 4.14 and 
4.15.
   the other pr is an improvement. it will not impact this pr.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to