sureshanaparti commented on a change in pull request #4497:
URL: https://github.com/apache/cloudstack/pull/4497#discussion_r539227236
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -4230,4 +4223,26 @@ public boolean isSecureMode(String bootMode) {
return false;
}
+
+ private void setCpuTopology(CpuModeDef cmd, int vcpus, Map<String, String>
details) {
Review comment:
> @sureshanaparti yes. but I need to discuss with @div8cn about some
details. it will be an improvement in 4.16
OK, Pls update details here. As this PR is targeted for 4.14.1.0, the
proposed changes with cpu hyperthreading detail will be targeted for 4.16,
Right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
