stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r389899042
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/HiddenGroupCombinatorParser.scala ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.processors.parsers + +import org.apache.daffodil.processors.ModelGroupRuntimeData + +/** + * The purpose of this combinator is to increment/decrement the depth counter + * for hidden groups, call the group's parser. As we get deeper into the + * hiddenGroupRefs, we'll increment the counter, call the group's parser, and as + * we unwind from the refs, we'll decrement. + */ +class HiddenGroupCombinatorParser( + ctxt: ModelGroupRuntimeData, bodyParser: Parser) + extends CombinatorParser(ctxt) { + + override lazy val childProcessors = Vector(bodyParser) + + override lazy val runtimeDependencies = Vector() + + def parse(start: PState): Unit = { + start.incrementHiddenDef + + // parse + bodyParser.parse1(start) + + start.decrementHiddenDef Review comment: Same here, probably need a try/finally. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
