mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r389898693
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/runtime1/SequenceTermRuntime1Mixin.scala
##########
@@ -76,7 +77,8 @@ trait ChoiceBranchImpliedSequenceRuntime1Mixin { self:
ChoiceBranchImpliedSequen
None,
Maybe.Nope,
Maybe.Nope,
- Maybe.Nope)
+ Maybe.Nope,
+ isHidden)
Review comment:
This should always be false here. I.e., a ChoiceBranchImpliedSequence cannot
be created for a group ref. So you can write
```
{
Assert.invariant(!isHidden)
false
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
