mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r389908595
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ModelGroupGrammarMixin.scala
##########
@@ -68,9 +69,16 @@ trait ModelGroupGrammarMixin
case c: ChoiceTermBase => DelimiterStackCombinatorChoice(c, content)
case s: SequenceTermBase => DelimiterStackCombinatorSequence(s,
content)
}
- } else { groupContentDef }
+ } else {
+ groupContent
+ } //TODO: confirm this works; changed from groupContentDef
- finalContent
+ val mgrd = self.modelGroupRuntimeData
+ if (mgrd.isHidden) {
Review comment:
Good point. This is the schema compiler, so we shouldn't be asking the
runtime data objects, but the DSOM object.
The schema compiler creates the runtime data objects, but shouldn't use
them. What they contain is in service of the runtime.
Interestingly, it's possible that ModelGroupRuntimeData doesn't need an
isHidden member. Whether the parser/unparser is traversing a hidden group ref
or not is represented by way of there being a HiddenGroupParser/Unparser
constructed. So possibly we don't even need ModelGroupRuntimeData.isHidden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
