mbeckerle commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r389894066
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala ########## @@ -732,9 +728,8 @@ trait Term final def possibleFirstChildElementsInInfoset: Seq[ElementBase] = LV('possibleFirstChildElementsInInfoset) { val pfct = possibleFirstChildTerms val firstChildren = pfct.flatMap { - case e: ElementBase if e.isHidden => Nil case e: ElementBase => Seq(e) - case s: SequenceTermBase if s.isHidden => Nil + case gr: GroupRef if gr.asModelGroup.isHidden => Nil Review comment: The more I read this code the more I want to suggest changing this member name from isHidden to isHiddenGroupRef. That seems easier than the other clarifying change which would be to move isHidden onto GroupRef and remove it from ModelGroup. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services