stevedlawrence commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392946570
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/GroupRef.scala ########## @@ -30,6 +30,11 @@ trait GroupRef { self: ModelGroup => final def referredToComponent = groupDef + /** + * Override in sequenceGroupRef and choiceGroupRef for hidden groups + */ + def isHidden = false Review comment: Not a big deal at all, but more from a style perspective, I'm wondering if it makes sense to not provide a default value for this, so it's just ``def isHidden: Boolean``. The only two things that mixin ``GroupRef``s are ``SequenceGroupRef`` and ``ChoiceGroupRef`` and they both overridden this already. And if there's ever somthing else that mixes in ``GroupRef``, they'll be forced to think about how ``isHidden`` should be set or they'll get a compile error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services