mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r390396869
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
##########
@@ -480,6 +480,17 @@ abstract class ParseOrUnparseState protected (
res
}
+ private var _hiddenDepth = 0
+
+ def incrementHiddenDef = {
+ _hiddenDepth += 1
+ }
+ def decrementHiddenDef = {
+ _hiddenDepth -= 1
+ }
+
+ def withinHiddenNest: Boolean = _hiddenDepth > 0
Review comment:
The word "nest" here is important. The concept here is that the runtime is
beneath/inside a hidden group, but not directly/statically, but anywhere within
the dynamic context nest.
I'm open to other names, but the goal is to denote the dynamic extent of the
hidden group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services