mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r392525136
##########
File path:
daffodil-cli/src/it/scala/org/apache/daffodil/debugger/TestCLIDebugger.scala
##########
@@ -900,10 +900,14 @@ class TestCLIdebugger {
}
@Test def test_CLI_Debugger_InfoHidden_1() {
- val schemaFile =
Util.daffodilPath("daffodil-test/src/test/resources/org/apache/daffodil/section14/sequence_groups/SequencesWithHiddenRefs.dfdl.xsd")
- val inputFile =
Util.daffodilPath("daffodil-cli/src/it/resources/org/apache/daffodil/CLI/input/test_isHidden1.txt")
- val (testSchemaFile, testInputFile) = if (Util.isWindows)
(Util.cmdConvert(schemaFile), Util.cmdConvert(inputFile)) else (schemaFile,
inputFile)
-
+ val schemaFile = Util.daffodilPath(
Review comment:
Really bugs me that every one of these tests (not just your new ones) has
this repeated isWindows conditionalization.
We really should be able to abstract this away so that tests don't have this
baggage over and over.
These same 6 lines of code are repeated a lot.
```
val (testSchemaFile, testInputFile) = if (Util.isWindows) {
(Util.cmdConvert(schemaFile),
Util.cmdConvert(inputFile.getAbsolutePath))
} else {
(schemaFile, inputFile)
}
val shell = if (Util.isWindows) Util.start("", envp =
DAFFODIL_JAVA_OPTS) else Util.start("")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
