stevedlawrence commented on a change in pull request #326: Daffodil 2280
cleanup - removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393636043
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -264,7 +267,7 @@ trait ElementBase
private lazy val myOwnNSPairs: Set[(String, NS)] =
thisElementsRequiredNamespaceBindings
private lazy val myParentNSPairs: Set[(String, NS)] = LV('myParentNSPairs) {
- val ee: Option[ElementBase] = enclosingElement
+ val ee: Option[ElementBase] = enclosingElements.headOption // FIXME: works
only if there is no difference among usages.
Review comment:
Does this need to change? It's not clear to me what the problem here is
based on the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
