stevedlawrence commented on a change in pull request #422:
URL: https://github.com/apache/incubator-daffodil/pull/422#discussion_r499591717
##########
File path: .github/workflows/main.yml
##########
@@ -20,81 +20,98 @@ on: [push, pull_request]
jobs:
test:
name: Java ${{ matrix.java_version }}, Scala ${{ matrix.scala_version }},
${{ matrix.os }}
- runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
- java_version: [ '8.x', '9.x', '11.x' ]
- scala_version: [ '2.12.11', '2.11.12' ]
- os: [ 'ubuntu-latest', 'windows-latest' ]
+ java_version: [ 8, 9, 11 ]
+ scala_version: [ 2.12.11, 2.11.12 ]
Review comment:
Yep. I'd avoid rebase until current discussions die down though.
Sometimes github gets confused during a rebase and some discussions can be lost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
