stevedlawrence commented on a change in pull request #422:
URL: https://github.com/apache/incubator-daffodil/pull/422#discussion_r499665371
##########
File path: daffodil-runtime2/src/main/c/common_runtime.c
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
Are you suggesting this would be too large to compile along with the
generated code?
Looks like JNI code includes compiled libraries in the jar and then uses
System.load to load the libraries:
https://stackoverflow.com/questions/2937406/how-to-bundle-a-native-library-and-a-jni-library-inside-a-jar
We can probably distribute the static library in the jar, and then the
c-generator can extract it when needed. I don't think there's a need for
System.load since the runtime isn't actually executing that code. But that
suggests the right distribution medium is withing the jar. The C headers still
need to be included in the the jar and extracted to allow the generated code
to be compiled with it though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
