mbeckerle commented on a change in pull request #422:
URL: https://github.com/apache/incubator-daffodil/pull/422#discussion_r499654666
##########
File path: daffodil-runtime2/src/main/c/common_runtime.c
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
Eventually, this "static code" is going to become a rather large
library. As big as both runtime1 parser and unparser together. Bigger given
that this is C code, in terms of Lines of code of course. Think in terms of 50K
lines of code kind of library. So I think it needs to be built as a static
library.
I am somewhat surprised that just putting c code into src/main/c and
/src/main/h doesn't just work transparently. We can't be the first project
mixing C code and Java/scala using SBT. Lots of JNI project must do this right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
