mbeckerle commented on a change in pull request #422:
URL: https://github.com/apache/incubator-daffodil/pull/422#discussion_r499696824
##########
File path: daffodil-runtime2/src/main/c/common_runtime.c
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
By "shared" library, I did not intend to suggest ".so" vs. ".a", but
just "shared" generally, as in not need to be duplicated. I do understand many
users would want ".a" type linkage.
I think we want people to be able to run TDML tests against the C-generating
backend. Leveraging TDML tests for the overlapping portable subset of DFDL that
both backends support is critical to success.
That suggests we need some "on the fly" way of compiling, linking, and
running the C code.
As for packaging for "real" usage like when the user just wants to complile
their DFDL schema and take away the C-code to some other system, I'm less
concerned about this. Just creating a zip/jar of the include and C-code
directories would seem sufficient to me. But we do want it to be 100% clear
what part is generated, and so if they recompile the schema, would be discarded
and overwritten by new generated code. That needs to be distinguished from the
static "library" code (and its headers) which would not be regenerated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
