jw3 commented on a change in pull request #431:
URL: https://github.com/apache/incubator-daffodil/pull/431#discussion_r512171719



##########
File path: 
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala
##########
@@ -673,7 +673,7 @@ sealed class ElementRuntimeData(
   def isSimpleType = optPrimType.isDefined
 
   def schemaURIStringsForFullValidation = 
schemaURIStringsForFullValidation1.distinct
-  private def schemaURIStringsForFullValidation1: Seq[String] = 
(schemaFileLocation.uriString +:
+  def schemaURIStringsForFullValidation1: Seq[String] = 
(schemaFileLocation.uriString +:

Review comment:
       > btw: this public member should definitely be a lazy val, not a def. So 
please change that also. No need for this to be computed over and over.
   
   done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to