jw3 commented on a change in pull request #431:
URL: https://github.com/apache/incubator-daffodil/pull/431#discussion_r512170596
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala
##########
@@ -673,7 +673,7 @@ sealed class ElementRuntimeData(
def isSimpleType = optPrimType.isDefined
def schemaURIStringsForFullValidation =
schemaURIStringsForFullValidation1.distinct
- private def schemaURIStringsForFullValidation1: Seq[String] =
(schemaFileLocation.uriString +:
+ def schemaURIStringsForFullValidation1: Seq[String] =
(schemaFileLocation.uriString +:
Review comment:
> No I don't get it. Why isn't just using the public
schemaURIStringForFullValidation sufficient?
~~Good question. I have no idea really, but was just trying to keep the
original behavior as consistent as possible through my changes. I havent saw
any tests break while refactoring so Im thinking there is no coverage on these
parts :)~~
I see, will fix it..
I did make that package private in a commit that snuck in during your review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
