michael-hoke commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r886067643
##########
src/language/semantics/xsltSnippets.ts:
##########
@@ -0,0 +1,178 @@
+/*---------------------------------------------------------------------------------------------
+ * Licensed under the MIT License. See License.txt in the project root for
license information.
+
*--------------------------------------------------------------------------------------------*/
+
+export interface Snippet {
+ name: string
+ body: string
+ description: string
+}
+
+export class XSLTSnippets {
+ static xsltRootTags: Snippet[] = [
Review Comment:
short answer - maybe not?
longer answer - The XSLT-related files are pretty integrated into the code
that tokenizes what we identify as XPath, so we may or may not be able to
remove the XSLT-related files. The main deterrent for this, from what I
remember, was the XsltTokenDiagnostics invocation needed right after we
identify the sections of the DFDL schema that should be treated as XPath (for
colorization/highlighting).
Also, random side-note, but based on the name and position of the
XsltTokenDiagnostics call, I think it might display error messages in vscode if
there are any syntax errors in the XPath (unknown if this is actually the case
or not). If this is the case, it might be that the files that are XSLT-related
are dual-purpose between XSLT and XPath.
I'd be happy to look into either removing the XSLT files or at least pulling
out the strictly-XSLT pieces and renaming them XPath/XP, but I don't think this
will be a quick fix, so can we consider creating an issue and looking into it
separately from this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
