michael-hoke commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r887026747
##########
src/language/semantics/xsltSnippets.ts:
##########
@@ -0,0 +1,178 @@
+/*---------------------------------------------------------------------------------------------
+ * Licensed under the MIT License. See License.txt in the project root for
license information.
+
*--------------------------------------------------------------------------------------------*/
+
+export interface Snippet {
+ name: string
+ body: string
+ description: string
+}
+
+export class XSLTSnippets {
+ static xsltRootTags: Snippet[] = [
Review Comment:
Unless I'm missing something, we no longer have semantic colorization now?
So that XPath expressions in DFDL attributes/elements are just solid string
colored? If that's the desired behavior, remove DeltaXML as a dependency
because we're not using it for anything else, as far as I can remember. We
weren't using the whole DeltaXML plugin codebase anyway - the code that was
taken was a minimum amount to grab to get semantic highlighting to work (might
be able to reduce that further by taking out XSLT as discussed above).
Doing this for the tag highlighting extension is fine I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
