michael-hoke commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r887210231
##########
src/language/semantics/xsltSnippets.ts:
##########
@@ -0,0 +1,178 @@
+/*---------------------------------------------------------------------------------------------
+ * Licensed under the MIT License. See License.txt in the project root for
license information.
+
*--------------------------------------------------------------------------------------------*/
+
+export interface Snippet {
+ name: string
+ body: string
+ description: string
+}
+
+export class XSLTSnippets {
+ static xsltRootTags: Snippet[] = [
Review Comment:
Thanks for sending me the vsix files. Unfortunately, neither of them are
working the way I would expect them to... So, this stopped working at some
point...
The way I see it, we have a few options here:
- Keep the code as we have it currently, which doesn't highlight embedded
XPath, remove the dependency on DeltaXML. Mark that this is the expected
behavior.
- Keep the code as we have it currently, open an issue on getting this
functionality back in separately from the PR (which would involve looking into
taking out the XSLT files). This would mean including a subset of the DeltaXML
plugin, which would require us to figure out the licensing information for
those. A first step for this would be to add the dependency to deltaXML back in
but figure out how to give the plugin the XPath segments so that we wouldn't
have to include that code in our extension.
- Revert the commit, remove only the tag-highlighting, and get this working
as a part of this PR (with or without potential XSLT pruning).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
