michael-hoke commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r887063633


##########
src/language/semantics/xsltSnippets.ts:
##########
@@ -0,0 +1,178 @@
+/*---------------------------------------------------------------------------------------------
+ *  Licensed under the MIT License. See License.txt in the project root for 
license information.
+ 
*--------------------------------------------------------------------------------------------*/
+
+export interface Snippet {
+  name: string
+  body: string
+  description: string
+}
+
+export class XSLTSnippets {
+  static xsltRootTags: Snippet[] = [

Review Comment:
   Between the { }, it should look like you would expect code to look. The 
if/else/then statements should be highlighted as keywords, numbers should be 
highlighted in a different color, fn:exists should be highlighted as a 
function, the ../NetworkLayer/IPv4 should be identified as a node (might be 
colored differently), and the strings should be treated like strings.
   
   You can use the "Developer: Inspect Editor Tokens and Scopes" command to see 
what semantic tags are being given to the different parts. I'm curious as to 
whether the semantic highlighting is now working on non-XPath, and if it's 
overwriting any syntactic highlighting on the rest of the file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to