stevedlawrence commented on code in PR #117: URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r886768656
########## src/language/dfdl.ts: ########## @@ -0,0 +1,1328 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import * as vscode from 'vscode' + +export function activate(context: vscode.ExtensionContext) { + const elementCompletionProvider = + vscode.languages.registerCompletionItemProvider('dfdl', { + provideCompletionItems( + document: vscode.TextDocument, + position: vscode.Position, + token: vscode.CancellationToken, + context: vscode.CompletionContext + ) { + const wholeLine = document + .lineAt(position) + .text.substr(0, position.character) + if (checkBraceOpen(document, position)) { + console.log('in elementCompletionProvider - brace is showing open') + return undefined + } + if (wholeLine.includes('Variable')) { + return undefined + } Review Comment: Should we explicitly specify dfdl:defineVariable/dfdl:setVariable in that case? What if someone has something like: ```xml <xs:element name="Variable" dfdl: | ``` And tries to autocomplete? Doesn't that line contain Variable and so will be ignored? Even that could run into edge cases. For example, what if we had this all on one line: ```xml <dfd:defineVariabile ...></dfdl:defineVariable><xs:element name="Foo" | ``` That's probably not a good idea to write DFDL link that, but would the autocomplete here would be ignored even though we're not in a defineVariable element? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
