stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r886752260
##########
src/language/semantics/xsltSnippets.ts:
##########
@@ -0,0 +1,178 @@
+/*---------------------------------------------------------------------------------------------
+ * Licensed under the MIT License. See License.txt in the project root for
license information.
+
*--------------------------------------------------------------------------------------------*/
+
+export interface Snippet {
+ name: string
+ body: string
+ description: string
+}
+
+export class XSLTSnippets {
+ static xsltRootTags: Snippet[] = [
Review Comment:
A quick search finds multiple XPath parsers/lexers available via npm. Seems
like just using one of those as dependency instead copying in 10,000+ lines of
XSLT parsers makes a lot more sense if all we need it for is XPath parsing.
> I'd be happy to look into either removing the XSLT files or at least
pulling out the strictly-XSLT pieces and renaming them XPath/XP, but I don't
think this will be a quick fix, so can we consider creating an issue and
looking into it separately from this PR?
Can we just remove highlighting for XPath expressions, and add support later
using something more specific? I am pretty averse to pulling in so much code
(of which I'm not sure we got an answer of where it came from) that seems 90%
unrelated to what this extension is about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
