stevedlawrence commented on code in PR #117: URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r885996892
########## src/omega_edit/server.ts: ########## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import * as vscode from 'vscode' +import * as fs from 'fs' +import * as unzip from 'unzip-stream' +import * as os from 'os' +import * as child_process from 'child_process' +import { HttpClient } from 'typed-rest-client/HttpClient' +import XDGAppPaths from 'xdg-app-paths' + +const xdgAppPaths = XDGAppPaths({ name: 'omega_edit' }) + +class Backend { + constructor(readonly owner: string, readonly repo: string) {} +} + +class Artifact { + constructor(readonly omegaEditVersion: string) {} + + name = `omega-edit-scala-server-${this.omegaEditVersion}` + archive = `${this.name}.zip` + archiveUrl = (backend: Backend) => + `https://github.com/${backend.owner}/${backend.repo}/releases/download/v${this.omegaEditVersion}/${this.archive}` + + scriptName = os.platform().toLowerCase().startsWith('win32') + ? 'example-grpc-server.bat' + : './example-grpc-server' + + getOsFolder() { + if (os.platform().toLowerCase().startsWith('win')) { + return 'windows' + } else if (os.platform().toLowerCase().startsWith('darwin')) { + return 'macos' + } else { + return 'linux' + } + } +} + +// Method to get omegaEditVersion from a JSON file +export function getOmegaEditVersion(filePath: fs.PathLike) { + return JSON.parse(fs.readFileSync(filePath).toString())['omegaEditVersion'] +} + +export async function startServer(ctx: vscode.ExtensionContext) { + // Get omegaEditVersion + const omegaEditVersion = getOmegaEditVersion( + ctx.asAbsolutePath('./package.json') + ) + const artifact = new Artifact(omegaEditVersion) + const backend = new Backend('ctc-oss', 'omega-edit') Review Comment: Yeah, the info you've added to bin.NOTICE isn't quite right. It should only include the content from the NOTICE file of the dependency if they have one. You don't need license/homepage information. And you don't need to include deps if they don't have a NOTICE file. Though, I think maybe we started doing that to make it easier to verify that all deps are accounted for? @tuxji, I think you switch things to that? Is that the case or am I making that up? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
