stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r886867014
##########
src/language/semantics/xsltSnippets.ts:
##########
@@ -0,0 +1,178 @@
+/*---------------------------------------------------------------------------------------------
+ * Licensed under the MIT License. See License.txt in the project root for
license information.
+
*--------------------------------------------------------------------------------------------*/
+
+export interface Snippet {
+ name: string
+ body: string
+ description: string
+}
+
+export class XSLTSnippets {
+ static xsltRootTags: Snippet[] = [
Review Comment:
I see now. Thanks for the reference.
So it looks like a large chunk of two extensions were copied into the VS
Cdoe repo:
* https://github.com/vincaslt/vscode-highlight-matching-tag
* https://github.com/DeltaXML/vscode-xslt-tokenizer
This is fine from a licensing perspective since they are MIT. But the xslt
tokenizer feels really excessive and unnecessary. Especially considering DFDL
XPath is a small subset of actual XPath. I'd suggest try ripping it out first
and see how it goes.
Also, regarding the highlight-matching-tag extension that was copied in, is
there no way to install that separately and then just have some way for this
extension to enable it for DFDL files? Or alternatively, could we create a pull
request to their extension so that it can work on DFDL or XSD files? I really
don't want to get into the habit of straight copying entire extensions just to
get the same features to work on DFDL files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
