stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r889254035


##########
INTELLISENSE.md:
##########
@@ -0,0 +1,75 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+      http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+# Apache Daffodil VS Code Extension Intellisense README
+
+The "Apache Daffodil VS Code Extension" extension provides auto completion for 
Data Format Description Language (DFDL) schemas.
+
+## Set the editor to dfdl mode
+
+![TurnOnDfdlMode](https://user-images.githubusercontent.com/98881959/152995118-e2da5835-027e-4ff7-90f9-baf36a7e04bb.gif)
+
+## Features
+
+Auto suggest is triggered using control space or typing the beginning 
characters of an item.
+![CtrlSpaceTrigger](https://user-images.githubusercontent.com/98881959/152995218-65d5b5b6-b610-495d-af31-69dd81be58c1.gif)
+
+Typing one or more unique characters will further limit the results.
+![CharacterTrigger](https://user-images.githubusercontent.com/98881959/152995254-1de6d39e-a482-4cb5-b7f3-7444932d056f.gif)
+
+Add the schema block
+![SchemaBlock](https://user-images.githubusercontent.com/98881959/152995294-7d70b7c6-186b-41e1-8a48-81ebfc3e04bc.gif)
+
+Completing a DFDL Format Block.
+![DfdlFormat](https://user-images.githubusercontent.com/98881959/152995321-ef0b2d45-32e6-4e3a-b5aa-859aa937cc3a.gif)
+
+The '>' or '/' characters are used to close and XML tag.
+Typing the initial characters and one or more unique characters will further 
limit the results.
+Use the Tab to select an item from the drop down and to exit double quotes
+![TabToExitQuotesAndEndTag](https://user-images.githubusercontent.com/98881959/152995446-77a33620-7277-4d9a-8dd7-f88349299ec9.gif)
+
+Creating self define dfdl:complextypes and dfdl:simpleTypes.
+![SelfDefinedTypes](https://user-images.githubusercontent.com/98881959/152995652-e56bc55d-78ba-46f6-a26c-6d7bd4440e96.gif)
+
+The tab key can be used to complete an auto-complete item within an XML tag.
+After auto complete is triggered, typing the initial character or characters 
will limit the suggestion results.
+Inside an XML tag a space or carriage return will trigger a list of context 
sensitive attribute suggestions.
+![AttributeSuggestions](https://user-images.githubusercontent.com/98881959/152995682-466be4bb-7f3f-4dcc-84bc-09792bc26adc.gif)
+
+Using self defined types.
+![UsingSelfDefinedTypes](https://user-images.githubusercontent.com/98881959/152995737-2f31e4e8-525d-4cb5-a5d7-a0413a087a54.gif)
+
+Using xs:choice and dfdl:Discriminator.
+![ChoiceDiscriminator](https://user-images.githubusercontent.com/98881959/152995769-b6afda2b-dd77-4f7a-ad18-b3e1f28087f6.gif)
+
+Using hidden references and dfdl:inputValueCalc
+![HiddenRefGroupAndInputValueCalc](https://user-images.githubusercontent.com/98881959/153010643-9d1c8361-b55d-45e4-a7a4-907ec876de76.gif)
+
+Using dfdl:OutputValueCalc
+![OutputValueCalc](https://user-images.githubusercontent.com/98881959/153051326-2b9d03ce-3e3a-420a-abba-408b25a2c3d2.gif)
+
+More examples of using user defined types
+![MoreUsingUserDefinedTypes](https://user-images.githubusercontent.com/98881959/153051453-e76250e2-96f6-4f07-8e9a-0a77f9ece5fe.gif)
+
+Using the dfdl:Length attribute with XPath values
+![DfdlLengthWithXPaths](https://user-images.githubusercontent.com/98881959/153051544-78372145-98aa-4b56-84f4-8b3a3bca4d9f.gif)
+
+Using dfdl:assert blocks
+![AssertBlock](https://user-images.githubusercontent.com/98881959/153051732-fb948f86-3485-4606-9e92-8325f1d5052d.gif)
+
+Miscellaneous examples
+![MoreExamples](https://user-images.githubusercontent.com/98881959/153051821-abc47704-878f-4c01-8a29-c0d3911940d0.gif)

Review Comment:
   At a minimum, I think we should remove the references to external images in 
this PR.
   
   If you want to just remove it entirely we can figure out where the 
documentation and associated images want to live. That could be in this repo, 
or  maybe the github wiki, website, etc. Lots of options to consider. I don't 
mind waiting until after this is merged to have that discussion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to