stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r893667415
##########
language/syntaxes/dfdl.tmLanguage.json:
##########
@@ -0,0 +1,387 @@
+{
+ "information_for_contributors": [
+ "This file has been converted from
https://github.com/atom/language-xml/blob/master/grammars/xml.cson";,
+ "If you want to provide a fix or improvement, please create a
pull request against the original repository.",
+ "Once accepted there, we are happy to receive an update
request."
+ ],
+ "version":
"https://github.com/atom/language-xml/commit/7bc75dfe779ad5b35d9bf4013d9181864358cb49";,
Review Comment:
According to these links, this file is no ALv2 license. We need to track
down the original license (it seems this file has been copied multiple times?)
and ensure it works with ALv2 and mention it in the LICENSE file.
##########
package.json:
##########
@@ -2,8 +2,9 @@
"name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil VS Code Extension",
"description": "VS Code extension for Apache Daffodil DFDL schema debugging",
- "version": "1.0.0",
+ "version": "1.1.0-SNAPSHOT",
"daffodilVersion": "3.3.0",
+ "omegaEditServerHash": "b12a2955290c3776129d9fbc8f543436",
Review Comment:
MD5 really shouldn't be used anymore. Apache usually recommends sha512.
##########
project/Rat.scala:
##########
@@ -35,7 +40,7 @@ object Rat {
lazy val MIT_LICENSE_NAME = "MIT License"
- lazy val MIT_LICENSE_TEXT_MICROSOFT =
Review Comment:
I would suggest keeping the name of this `MIT_LICENSE_TEXT_MICROSOFT` since
this is an MIT license that includes microsoft copyrights. If we ever need to
match against an MIT license with different coprights, we'll need a different
name.
##########
package.json:
##########
@@ -186,18 +229,49 @@
"category": "Daffodil Debug",
"enablement": "!inDebugMode",
"icon": "$(debug-configure)"
+ },
+ {
+ "command": "toggle.experimental",
+ "title": "Enable Experimental Features",
+ "category": "Daffodil Debug"
+ },
+ {
+ "command": "omega_edit.version",
+ "title": "Omega Edit Ω Version Info",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ },
+ {
+ "command": "data.edit",
+ "title": "Data Editor",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ },
+ {
+ "command": "position.goto",
+ "title": "Go to position",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ }
+ ],
+ "keybindings": [
+ {
+ "command": "position.goto",
+ "key": "ctrl+alt+g",
+ "mac": "ctrl+cmd+g",
+ "when": "editorTextFocus"
}
],
"breakpoints": [
{
- "language": "xml"
+ "language": "dfdl"
}
],
"debuggers": [
{
"type": "dfdl",
"languages": [
- "xml"
+ "dfdl"
Review Comment:
I'd suggest looking at treating this as just normal XML so we get all the
normal XML features and don't need to reimplement that. And then find a way to
add capabilities for XML files that are detected to be DFDL. Not sure if that's
possible, but seems like a much better approach from a funcionality
perspective--we shouldn't need to reimplement XML capabilities.
##########
package.json:
##########
@@ -23,26 +23,37 @@
"url": "https://github.com/apache/daffodil-vscode/issues";
},
"scripts": {
+ "omega-edit-download": "tsc -p ./ && node -e
'require(\"./out/omega_edit/download.js\").downloadServer()'",
"vscode:prepublish": "yarn run package-ext",
"precompile": "node -p \"'export const LIB_VERSION = ' +
JSON.stringify(require('./package.json').version) + ';'\" > src/version.ts",
- "compile": "tsc -p ./",
+ "compile": "tsc -p ./ && node out/omega_edit/download.js",
Review Comment:
Still doesn't work for me. The omega edit zip file is not downloaded during
the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
