stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r893836974


##########
language/syntaxes/dfdl.tmLanguage.json:
##########
@@ -0,0 +1,387 @@
+{
+       "information_for_contributors": [
+               "This file has been converted from 
https://github.com/atom/language-xml/blob/master/grammars/xml.cson";,
+               "If you want to provide a fix or improvement, please create a 
pull request against the original repository.",
+               "Once accepted there, we are happy to receive an update 
request."
+       ],
+       "version": 
"https://github.com/atom/language-xml/commit/7bc75dfe779ad5b35d9bf4013d9181864358cb49";,

Review Comment:
   I'm building from commit 32eace89d73adc9f2f94feb97e4d7da1717cbf23, which I 
think is the latest.
   
   > But you can test running yarn run omega-edit-download to see if it works
   
   That does work. Is the difference that the "compile" script is just this
   
   `"tsc -p ./ && node out/omega_edit/download.js`
   
   The oega-edit-download script is this:
   
   `"tsc -p ./ && node -e 
\"require('./out/omega_edit/download.js').downloadServer()\""`
   
   I'm not sure why those two are different, or why we need the download in 
both places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to