stevedlawrence commented on code in PR #117:
URL: https://github.com/apache/daffodil-vscode/pull/117#discussion_r893765800
##########
package.json:
##########
@@ -186,18 +229,49 @@
"category": "Daffodil Debug",
"enablement": "!inDebugMode",
"icon": "$(debug-configure)"
+ },
+ {
+ "command": "toggle.experimental",
+ "title": "Enable Experimental Features",
+ "category": "Daffodil Debug"
+ },
+ {
+ "command": "omega_edit.version",
+ "title": "Omega Edit Ω Version Info",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ },
+ {
+ "command": "data.edit",
+ "title": "Data Editor",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ },
+ {
+ "command": "position.goto",
+ "title": "Go to position",
+ "category": "OmegaEdit",
+ "enablement": "experimentalFeaturesEnabled"
+ }
+ ],
+ "keybindings": [
+ {
+ "command": "position.goto",
+ "key": "ctrl+alt+g",
+ "mac": "ctrl+cmd+g",
+ "when": "editorTextFocus"
}
],
"breakpoints": [
{
- "language": "xml"
+ "language": "dfdl"
}
],
"debuggers": [
{
"type": "dfdl",
"languages": [
- "xml"
+ "dfdl"
Review Comment:
Understood. That's fine for now, but I think in general we need to be very
careful about what we copy in, and it should be avoided as much as possible.
Every piece of some other extension we copy in is just one more thing that we
need to maintain, and that just isn't a long term viable solution if it happens
to many times and if the pieces are too big. I don't want to have to maintain
multiple XML extensions with one line tweaks to work with DFDL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
