stevedlawrence commented on code in PR #800:
URL: https://github.com/apache/daffodil/pull/800#discussion_r891142141
##########
daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/dafext.xsd:
##########
@@ -502,11 +502,11 @@
</xs:documentation>
</xs:annotation>
</xs:element>
- <xs:element name="tdmlImplementation" type="xs:string"
default="daffodil" minOccurs="0">
+ <xs:element name="tdmlImplementation"
type="daf:TunableTDMLImplementation" default="daffodil" minOccurs="0">
Review Comment:
Does this logic mean that you can't override a daffodilC tunable if you want
to test with runtime1? I'm not sure how likely that is, it's feels like a sign
of things being over complicated.
Feels complex to me. Seems like it would be easier to just specify two
different Runners with different implementations, and using runOneTest on the
appropriate tests using the appropriate runners. You could even add the
"implementation" attribute to the parser/unparserTestCase to ensure those tests
never run with the wrong implementation, and sort of document which
implementation the test should work with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
