stevedlawrence commented on code in PR #800:
URL: https://github.com/apache/daffodil/pull/800#discussion_r892289745
##########
daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala:
##########
@@ -1330,7 +1345,8 @@ object Main {
case s: scala.util.control.ControlThrowable => throw s
case u: UnsuppressableException => throw u
case e: TDMLTestNotCompatibleException => {
- println("[Skipped] %s (Not compatible
implementation.)".format(name))
+ println("[Skipped] %s (not compatible with implementation
%s)"
+ .format(name, e.implementation.getOrElse("<none>")))
Review Comment:
We must have an implementation here, right? How could a test not be
compatible with the implementation yet the exception doesn't know what
implementation isn't compatible?
Digging a bit, it looks like we just carry around the implementation in the
TDMLRunner as an `Option`. Which doesn't really make sense. We must always know
what implementation is being used. In fact, often times we just call
`impl.get`, so there's definitely an assumption that it's defined.
This is an existing problem so I don't suggest you fix it here, but maybe we
should open a new bug to change references to the implementation in the
TDMLRunner to not be an Option? That might be a good beginner bug for someone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
