stevedlawrence commented on code in PR #800:
URL: https://github.com/apache/daffodil/pull/800#discussion_r891148195
##########
daffodil-runtime2/src/test/resources/org/apache/daffodil/runtime2/ex_nums.tdml:
##########
@@ -38,21 +38,25 @@
<tdml:defineConfig name="config-runtime2">
<daf:tunables>
- <daf:tdmlImplementation>daffodil-runtime2</daf:tdmlImplementation>
+ <daf:tdmlImplementation>daffodilC</daf:tdmlImplementation>
</daf:tunables>
</tdml:defineConfig>
Review Comment:
I do see the value, but it also seems potentially confusing. Seems running a
command twice, with some tests skipped based on their "implementation"
attribute is more straightforward.
As a followup to previous comments, so if you run `daffodil test -I
daffodilC` then it overrides the tunable and runs all tests with daffodilC, but
if you run `daffodil test -I daffodil`, then it doesn't override the tunable,
and some tests are run with runtime1 and some with runtime2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
