stevedlawrence commented on code in PR #800:
URL: https://github.com/apache/daffodil/pull/800#discussion_r891150851


##########
daffodil-tdml-lib/src/main/scala/org/apache/daffodil/tdml/RunnerFactory.scala:
##########
@@ -37,28 +39,48 @@ import org.apache.daffodil.util.Misc
  */
 object Runner {
   def apply(dir: String, file: String,
+    useTDMLImplementation: TDMLImplementation = TDMLImplementation.Daffodil,

Review Comment:
   The TDML_IMPLEMENATION env variable is only used by the CLI. I don't think 
`TDML_IMPLEMENTATION="daffodilC" sbt test....` will work with these current 
changes, except I guess maybe with the CLI integration tests.
   
   I'm not sure if that's needed though, I'm fine if that's CLI only logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to