stevedlawrence commented on code in PR #800:
URL: https://github.com/apache/daffodil/pull/800#discussion_r892413654
##########
daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala:
##########
@@ -1330,7 +1345,8 @@ object Main {
case s: scala.util.control.ControlThrowable => throw s
case u: UnsuppressableException => throw u
case e: TDMLTestNotCompatibleException => {
- println("[Skipped] %s (Not compatible
implementation.)".format(name))
+ println("[Skipped] %s (not compatible with implementation
%s)"
+ .format(name, e.implementation.getOrElse("<none>")))
Review Comment:
Yeah, it seems reasonable for `TDMLException` to have an `Option`
implementation--some exceptions definitely happen before we know what the
implementation is.
But I don't think it shouldn't be an `Option` in the
`TDMLTestNotCompatibleImplementation` exception. Ideally that class should be
changed to accept a `String` and it creates a `Some(implementation)` when
passed to the TDMLExceptionImpl. I'm not sure if that's worth that change, but
you're right that TDMLException is probably the reason why it's an an Option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
