mbeckerle commented on code in PR #812:
URL: https://github.com/apache/daffodil/pull/812#discussion_r922554953
##########
daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala:
##########
@@ -662,14 +666,20 @@ object Main {
val blobSuffix = ".bin"
def getInfosetOutputter(infosetType: InfosetType.Type, os:
java.io.OutputStream)
- : Either[InfosetOutputter, DaffodilParseOutputStreamContentHandler] = {
+ : Either[InfosetOutputter, ContentHandler] = {
val outputter = infosetType match {
case InfosetType.XML => Left(new XMLTextInfosetOutputter(os, pretty =
true))
case InfosetType.SCALA_XML => Left(new ScalaXMLInfosetOutputter())
case InfosetType.JSON => Left(new JsonInfosetOutputter(os, pretty =
true))
case InfosetType.JDOM => Left(new JDOMInfosetOutputter())
case InfosetType.W3CDOM => Left(new W3CDOMInfosetOutputter())
- case InfosetType.SAX => Right(new
DaffodilParseOutputStreamContentHandler(os, pretty = true))
+ case InfosetType.EXI => {
+ val exiFactory = DefaultEXIFactory.newInstance()
+
exiFactory.getFidelityOptions.setFidelity(FidelityOptions.FEATURE_PREFIX, true)
+ val exiResult = new EXIResult()
Review Comment:
Is this also where we would turn on other options for the EXI encoder, like
telling it to compress the data to minimize its size?
##########
daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala:
##########
@@ -662,14 +666,20 @@ object Main {
val blobSuffix = ".bin"
def getInfosetOutputter(infosetType: InfosetType.Type, os:
java.io.OutputStream)
- : Either[InfosetOutputter, DaffodilParseOutputStreamContentHandler] = {
+ : Either[InfosetOutputter, ContentHandler] = {
val outputter = infosetType match {
case InfosetType.XML => Left(new XMLTextInfosetOutputter(os, pretty =
true))
case InfosetType.SCALA_XML => Left(new ScalaXMLInfosetOutputter())
case InfosetType.JSON => Left(new JsonInfosetOutputter(os, pretty =
true))
case InfosetType.JDOM => Left(new JDOMInfosetOutputter())
case InfosetType.W3CDOM => Left(new W3CDOMInfosetOutputter())
- case InfosetType.SAX => Right(new
DaffodilParseOutputStreamContentHandler(os, pretty = true))
+ case InfosetType.EXI => {
+ val exiFactory = DefaultEXIFactory.newInstance()
Review Comment:
So this is schema-independent EXI for now correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
